Remove empty string from global lists #1046
Merged
+22
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dj-34
approved these changes
Feb 27, 2024
AyIong
approved these changes
Feb 27, 2024
PhantornRU
reviewed
Feb 28, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Что этот PR делает
Из-за особенности работы
file2list, в частности использованияsplittext, глобальные списки имен имеют последним элементом пустую строку, что создает небольшую вероятность присваивания пустого имени кукле при случайной генерации. Думаю, удаление последней пустой строки в файлах должно исправить ишуе.Почему это хорошо для игры
На станции больше не будет ноунеймов (буквально).
Тестирование
Запустился локально, не нашел пустой строки в списках.
Changelog
🆑 Maxiemar
fix: Исправлена проблема с присваиванием персонажам пустого случайного имени.
/:cl: